Revert "Set height and width specifically on img tag"

This reverts commit be12afb50d.

It causes issues with aspect ratio when the raw width of the image is
wider than the width in CSS pixels allowed by the body max-width.

Not reverting the refactor that removes {{ $img = . }} because I don't
know why that was there and will see if it works fine with it still
removed.

assets/css/bobastyle.css

@@ -291,17 +291,17 @@ table.simple tbody tr:nth-child(even) {
 
 /* Icons */
 .icon {
-  width: 20px;
+  width: 1em;
-  height: 20px;
+  height: 1em;
   color: var(--text-1);
   text-align: center;
   display: inline;
-  vertical-align: middle;
+  vertical-align: sub;
 }
 
-h1 svg.icon {
+/* workarounds for some icons from jam-icons being non-square aspect ratio */
-  width: 30px;
+.icon-code {
-  height: 30px;
+  width: 1.25em;
 }
 
 /* }}} */
@@ -315,11 +315,6 @@ h1 svg.icon {
   font-weight: bold;
 }
 
-.heading-link svg {
-  width: 15px;
-  height: 15px;
-}
-
 /* }}} */
 
 /* Top bar formatting {{{ */
@@ -676,6 +671,7 @@ h1 svg.icon {
   display: flex;
   gap: 8px;
   justify-content: center;
+  font-size: 32px;
 }
 
 .share-buttons a {
@@ -690,8 +686,7 @@ h1 svg.icon {
 }
 
 .share-buttons svg {
-  width: 32px;
+  display: block;
-  height: 32px;
 }
 
 /* https://stackoverflow.com/a/72073682/19003757 */

assets/js/share-event.js

@@ -1,3 +0,0 @@
-function share_event(service) {
-    // this function does nothing by default
-}

layouts/_partials/figure.html

@@ -7,18 +7,17 @@
 {{ end }}
 
     {{ with index . "src" }}
-        {{ $media := . }}
         {{ if eq .MediaType.MainType "image" }}
-            <img src="{{ $media.Permalink }}" alt="{{ $media.Title }}" loading="lazy" />
+            <img src="{{ .Permalink }}" alt="{{ .Title }}" loading="lazy" />
         {{ else if eq .MediaType.MainType "video" }}
             <video controls preload="metadata">
-                <source src="{{ $media.Permalink }}" alt="{{ $media.Title }}">
+                <source src="{{ .Permalink }}" alt="{{ .Title }}">
                 {{ i18n "browser_no_video_support" }}
             </video>
         {{ end }}
 
         {{ if not $hidecaption }}
-            {{ with $media.Title }}
+            {{ with .Title }}
                 <figcaption>
                     {{ . | markdownify }}
                 </figcaption>

layouts/_partials/head.html

@@ -16,9 +16,6 @@
     {{ with resources.Get "js/bobatheme.js" | fingerprint "sha512" }}
         <script defer src="{{ .Permalink }}" integrity="{{ .Data.Integrity }}" crossorigin="anonymous"></script>
     {{ end }}
-    {{ with resources.Get "js/share-event.js" | fingerprint "sha512" }}
-        <script defer src="{{ .Permalink }}" integrity="{{ .Data.Integrity }}" crossorigin="anonymous"></script>
-    {{ end }}
 
     {{ with .Site.Params.faviconSVG }}
         <link rel="icon" href="{{ . | absURL }}" />

layouts/_partials/icon_code.html

@@ -1,6 +1,6 @@
 {{- $icon_resource := resources.Get (printf "jam/icons/%s.svg" .) -}}
 {{- $icon := $icon_resource.Content -}}
-{{- $icon = replaceRE `<svg` `<svg class="icon"` $icon -}}
+{{- $icon = replaceRE `<svg` (printf `<svg class="icon icon-%s"` .) $icon -}}
 {{- $icon = replaceRE `</svg>` (printf `<title>%s icon</title></svg>` .) $icon -}}
 {{- $icon = replaceRE `(width|height)="[0-9]*"` "" $icon -}}
 {{- $icon | safeHTML -}}

layouts/_partials/page-metadata/custom-full.html

@@ -0,0 +1 @@
+<!-- Placeholder for website to add custom post metadata to summaries -->

layouts/_partials/page-metadata/item/authors.html

@@ -1,5 +1,5 @@
 {{ with .Params.authors }}
-    <span class="page-metadata-item" aria-label="{{ i18n "aria_post_meta_authors" }}">
+    <span class="page-metadata-item" data-pagefind-meta="authors" aria-label="{{ i18n "aria_post_meta_authors" }}">
         {{ partial "icon.html" "user-circle" }}
 
         {{ if index $.Site.Taxonomies "authors" }}

layouts/_partials/page-metadata/item/categories.html

@@ -4,7 +4,7 @@
         {{ $categories = $categories | append (printf `<a href="%s">%s</a>` .Permalink .LinkTitle) }}
     {{ end }}
 
-    <div class="page-metadata-section categories" aria-label="{{ i18n "aria_post_meta_categories" }}">
+    <div class="page-metadata-section categories" data-pagefind-meta="categories" aria-label="{{ i18n "aria_post_meta_categories" }}">
         {{ partial "icon.html" "folder" }}
         {{ delimit $categories ", " | safeHTML }}
     </div>

layouts/_partials/page-metadata/item/series.html

@@ -4,7 +4,7 @@
         {{ $series = $series | append (printf `<a href="%s">%s</a>` .Permalink .LinkTitle) }}
     {{ end }}
 
-    <div class="page-metadata-section series" aria-label="{{ i18n "aria_post_meta_series" }}">
+    <div class="page-metadata-section series" data-pagefind-meta="series" aria-label="{{ i18n "aria_post_meta_series" }}">
         {{ partial "icon.html" "files" }}
         {{ delimit $series ", " | safeHTML }}
     </div>

layouts/_partials/page-metadata/item/tags.html

@@ -4,7 +4,7 @@
         {{ $tags = $tags | append (printf `<a href="%s">%s</a>` .Permalink .LinkTitle) }}
     {{ end }}
 
-    <div class="page-metadata-section tags" aria-label="{{ i18n "aria_post_meta_tags" }}">
+    <div class="page-metadata-section tags" data-pagefind-meta="tags" aria-label="{{ i18n "aria_post_meta_tags" }}">
         {{ partial "icon.html" "tag" }}
         {{ delimit $tags ", " | safeHTML }}
     </div>

layouts/_partials/page-metadata/post-full.html

@@ -22,6 +22,8 @@
         {{ partial "page-metadata/item/edithistory.html" . }}
         {{ partial "page-metadata/item/viewraw.html" . }}
 
+        {{ partial "page-metadata/custom-full.html" . }}
+
         {{ partial "page-metadata/item/categories.html" . }}
 
         {{ partial "page-metadata/item/tags.html" . }}

layouts/_partials/page-metadata/post-short.html

@@ -9,6 +9,7 @@
 
         {{ partial "page-metadata/item/authors.html" . }}
         {{ partial "page-metadata/item/readingtime.html" . }}
+
         {{ partial "page-metadata/item/series.html" . }}
         {{ partial "page-metadata/item/categories.html" . }}
         {{ partial "page-metadata/item/tags.html" . }}

layouts/_partials/seo-tags/opengraph.html

@@ -33,7 +33,7 @@
     <meta property="og:locale" content="{{ . }}">
 {{ end }}
 
-{{ with .Site.Params.title }}
+{{ with .Site.Title }}
     <meta property="og:site_name" content="{{ . }}">
 {{ end }}
 

layouts/_shortcodes/include.html

@@ -0,0 +1,14 @@
+{{/* https://github.com/gohugoio/hugo/issues/13823#issuecomment-3015270202 */}}
+{{ with .Get 0 -}}
+    {{ with $.Page.GetPage . -}}
+        {{ .RenderShortcodes -}}
+    {{ else with $.Page.Resources.Get . -}}
+        {{ .RenderShortcodes -}}
+    {{ else with resources.Get . -}}
+        {{ .Content -}}
+    {{ else -}}
+        {{ errorf "The %q shortcode was unable to find %q. See %s" $.Name . $.Position -}}
+    {{ end -}}
+{{ else -}}
+    {{ errorf "The %q shortcode requires a positional parameter indicating the logical path of the file to include. See %s" .Name .Position -}}
+{{ end -}}

layouts/baseof.html

@@ -8,12 +8,18 @@
 
         {{ partial "top.html" . }}
 
+        {{ if hugo.IsServer -}}
+            <div style="position: fixed; bottom: 25px; right: 25px;">
+                {{ templates.Current.Name }}
+            </div>
+        {{ end -}}
+
         <div class="main-container">
             {{ if not .IsHome }}
                 {{ partial "breadcrumb.html" . }}
             {{ end }}
 
-            <main id="main-content">
+            <main id="main-content" {{ if .IsPage }}data-pagefind-body{{ end }}>
                 {{ block "main" . }}
                     THIS TEXT SHOULD NOT SHOW. YUZSIQGHE (that string is so I can grep for it)
                 {{ end }}

layouts/shortcodes/include.html

@@ -1,20 +0,0 @@
-{{ $path := "" }}
-{{ $markdown := false }}
-{{ if .IsNamedParams }}
-    {{ $path = .Get "path" }}
-    {{ with .Get "markdown" }}
-        {{ $markdown = . }}
-    {{ end }}
-{{ else }}
-    {{ $path = .Get 0 }}
-{{ end }}
-
-{{ with ($path | readFile) }}
-    {{ if $markdown }}
-        {{ $path | readFile | $.Page.RenderString (dict "display" "block") }}
-    {{ else }}
-        {{ $path | readFile }}
-    {{ end }}
-{{ else }}
-    {{ errorf "file not found: %s" $path }}
-{{ end }}